Falling back to chroot() if pivot_root() fails #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Mikushin <[email protected]>
…ms; it could be replaced by a mount bind and chroot(), additionally unsharing and uid/gid mapping is not available Signed-off-by: Dmitry Mikushin <[email protected]>
Signed-off-by: Dmitry Mikushin <[email protected]>
dmikushin
force-pushed
the
falling-back-to-chroot-if-pivot_root-fails
branch
from
2f373e2
to
348156f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #594 I've found that bubblewrap fails due to
pivot_root(), when binding folder on an NFS filesystem. It would be a pity to fail the entire bubblewrap due to this problem. So I propose a fallback mode: ifpivot_root()fails, we try to continue setup withchroot(). Yes:chroot()yields some limitations, such as disabled unsharing mode and disabled uid/gid mapping. But it is still better than nothing, isn't it?